web: /v36_status reports real V35->V36 state (de-stub) - #372
Merged
Conversation
rest_v36_status() returned a hardcoded auto_ratchet.state="voting" with
v35_shares=0/v36_shares=0/v36_percentage=0.0 regardless of actual chain
state, only ever filling height/sample_size. On a node mid-cross this lied
about the V35->V36 transition (the founding-charter stub class) while the
sibling rest_version_signaling() already derived the truthful state and
percentages from the same chain data.
/v36_status now sources auto_ratchet.state and the v35/v36 share counts +
percentage from rest_version_signaling(). Non-transition coins (its early
{} return) leave truthful zeros; a too-short chain early-returns before the
overall_* fields, handled by .value() defaults. Read/web path only; pool
aggregates and consensus untouched.
Serves the live LTC prod V35->V36 cross (#288) crossing-visibility charter.
frstrtr
added a commit
that referenced
this pull request
Jun 23, 2026
web: /v36_status reports real V35->V36 state (de-stub)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rest_v36_status()(route/v36_status) returned a frozen stub:auto_ratchet.state="voting",v35_shares=0,v36_shares=0,v36_percentage=0.0regardless of real chain state — onlyheight/sample_sizewere ever populated. On a node mid-cross this lies about the V35->V36 transition (the founding-charter stub class the dashboard exists to kill).Fix
The sibling
rest_version_signaling()already derives the truthful ratchet state (voting/activated/confirmed) and v36 share counts/percentage from chain data./v36_statusnow sources from it:auto_ratchet.state/persisted_state<- derived effective stateshare_chain.{sample_size,v36_shares,v36_percentage}<-overall_total/overall_v36_shares/overall_v36_share_pctv35_shares=max(0, sample_size - v36_shares);heightstill from sharechain statsEdge cases: non-transition coins (DASH etc.) get
rest_version_signaling()empty{}, leaving truthful zeros; a too-short chain early-returns before theoverall_*fields, handled by.value()defaults.Scope
Read/web (non-consensus) path only — pool aggregates and consensus logic untouched. Builds clean locally (c2pool target links; only pre-existing stdlib warnings). Serves the live LTC prod V35->V36 cross (#288) crossing-visibility charter (#3). GPG-signed.